[BUG]: hostname validation is incomplete #31

New Issue

2026-09-15T19:42:20+04:00

max commented

2026-09-15 19:42:20 +04:00

📋 Description

Currently, it's possible to enter incorrect hostname and playbook won't throw an error

🔁 Steps to Reproduce

Run a deployment playbook
Enter hostname starting with hyphen
Some other invalid combinations work too

✅ Expected Behavior

Any invalid (checked against Proxmox rules) combination would cause playbook to fail with error

❌ Actual Behavior

Playbook doesn't fail and tries to pass an invalid value to Proxmox

📄 Logs / Screenshots

No response

📦 Audio Splitter Version

dev

💻 Operating System

Any

🌍 Browser (if applicable)

No response

📎 Additional Context

No response

✅ Submission Checklist

I have searched for existing issues (open and closed) that report the same problem
I am using the latest stable release of Audio Splitter
I have provided clear steps to reproduce the issue
I have included relevant logs or error messages (with sensitive info removed)

### 📋 Description Currently, it's possible to enter incorrect hostname and playbook won't throw an error ### 🔁 Steps to Reproduce 1. Run a deployment playbook 2. Enter hostname starting with hyphen 3. Some other invalid combinations work too ### ✅ Expected Behavior Any invalid (checked against Proxmox rules) combination would cause playbook to fail with error ### ❌ Actual Behavior Playbook doesn't fail and tries to pass an invalid value to Proxmox ### 📄 Logs / Screenshots _No response_ ### 📦 Audio Splitter Version dev ### 💻 Operating System Any ### 🌍 Browser (if applicable) _No response_ ### 📎 Additional Context _No response_ ### ✅ Submission Checklist - [x] I have searched for existing issues (open and closed) that report the same problem - [x] I am using the latest stable release of Audio Splitter - [x] I have provided clear steps to reproduce the issue - [x] I have included relevant logs or error messages (with sensitive info removed)

max added the bug label 2026-09-15 19:42:20 +04:00

max commented

2026-09-16 08:48:49 +04:00

Proxmox follows the usual domain name rules:

Allowed letters: a–z
Allowed digits: 0–9
Hyphens (-) and dots (.) are allowed, but they cannot be at the start or end
Label Length: Each segment can be between 1 and 63 characters long
Total Length: The complete name must not exceed 253 characters, including dots
NO spaces, UNICODE characters or special symbols

Proxmox follows the usual domain name rules: 1. Allowed letters: a–z 2. Allowed digits: 0–9 3. Hyphens (-) and dots (.) are allowed, but they cannot be at the start or end 4. Label Length: Each segment can be between 1 and 63 characters long 5. Total Length: The complete name must not exceed 253 characters, including dots 6. NO spaces, UNICODE characters or special symbols

max referenced a pull request that will close this issue

2026-09-16 17:53:59 +04:00

fix(pb): makes hostname validation strict enough #37

max closed this issue

2026-09-16 17:54:09 +04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: max/vmn-ansible#31